Skip to content

Bookings: Fetch filtered bookings on time tabs #16206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 6, 2025
Merged

Bookings: Fetch filtered bookings on time tabs #16206

merged 7 commits into from
Oct 6, 2025
+329 −26

Conversation

@itsmeichigo
Copy link
Contributor

@itsmeichigo itsmeichigo commented Oct 3, 2025 •
edited
Loading

Closes WOOMOB-1392

Description

This PR wraps up the tabs on the booking list. Changes include:

  • Calculates the min and max timestamps for each tab.
  • Updates network request and Core Data queries according to the timestamps.
  • Enables clearing cache upon pulling to refresh the list.
  • Updates the dates display on the list items to force using UTC timezone.
  • Restores loading bookings upon switching tabs to ensure correct data.
  • Updates booking query to sort by start date descending by default.

Testing steps

  1. Log in to a CIAB store with existing bookings.
  2. Switch to the Bookings tab and confirm that correct bookings are displayed on each tab.
  3. On the web, remove any booking. Then pull to refresh the list on the app and confirm that the removed booking is no longer on the list.

Testing information

  • Tested and verified with simulator iPhone 17.
  • Added unit tests for updated logic in the booking list view model.

Screenshots

Simulator.Screen.Recording.-.iPhone.17.-.2025-10-03.at.18.18.23.mov
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@itsmeichigo itsmeichigo added this to the 23.5 milestone Oct 3, 2025
@itsmeichigo itsmeichigo added the type: task An internally driven task. label Oct 3, 2025
@wpmobilebot
Copy link
Collaborator

wpmobilebot commented Oct 3, 2025 •
edited
Loading

App Icon📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS Prototype
Build Numberpr16206-2ea7c68
Version23.4
Bundle IDcom.automattic.alpha.woocommerce
Commit2ea7c68
Installation URL020c8dtc1c4f0
 Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@itsmeichigo itsmeichigo marked this pull request as ready for review October 3, 2025 11:53
RafaelKayumov
RafaelKayumov approved these changes Oct 6, 2025
View reviewed changes
Copy link
Contributor

@RafaelKayumov RafaelKayumov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Left just 1 UI related comment

WooCommerce/Classes/Bookings/BookingList/BookingListContainerView.swift
tabCount: BookingListTab.allCases.count,
selectedIndex: viewModel.selectedTab.rawValue))
selectedIndex: viewModel.selectedTab.rawValue),
y: -Layout.selectedTabIndicatorHeight / 2)
Copy link
Contributor

@RafaelKayumov RafaelKayumov Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be + for the indicator Y? In my testing the - lifts the indicator even higher from the view bottom.

Copy link
Contributor Author

@itsmeichigo itsmeichigo Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I'll fix this in the next PR #16211.

@itsmeichigo itsmeichigo merged commit 2e9f89b into trunk Oct 6, 2025
13 checks passed
@itsmeichigo itsmeichigo deleted the woomob-1392-booking-list-tabs-ui branch October 6, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RafaelKayumov RafaelKayumov RafaelKayumov approved these changes

Assignees

No one assigned

Labels

type: task An internally driven task.

Projects

None yet

Milestone

23.5

Development

Successfully merging this pull request may close these issues.

4 participants

@itsmeichigo @wpmobilebot @RafaelKayumov